Opened 6 years ago

Closed 5 years ago

Last modified 4 years ago

#613 closed Bug (fixed)

Bugs of MPC-HC Dialog Fonts

Reported by: unwake Owned by: v0lt
Priority: normal Milestone: 1.5.2
Component: General Version:
Severity: major Keywords:
Cc: Evaluation:

Description

Some Dialog's font shows badly, I open mplayer.rc and find the reason.

FONT 8, "MS Shell Dlg", 400, 0, 0xEE

should be fixed to

FONT 8, "MS Shell Dlg", 400, 0, 0x1

Attachments (3)

Subtitile.jpg (98.9 KB) - added by unwake 6 years ago.
Fonts looks bad
Fileassoc.jpg (64.2 KB) - added by unwake 6 years ago.
Fonts look good
mplayerc.7z (28.8 KB) - added by unwake 6 years ago.

Download all attachments as: .zip

Change History (22)

Changed 6 years ago by unwake

Fonts looks bad

Changed 6 years ago by unwake

Fonts look good

comment:1 Changed 6 years ago by alexx999

  • Component changed from New to Patch Welcome
  • Severity changed from major to trivial

than make a patch and upload it here

comment:2 Changed 6 years ago by xhmikosr

  • Severity changed from trivial to major

comment:3 Changed 6 years ago by unwake

I upload the fiexed mplayerc.rc, please check it.

comment:4 Changed 6 years ago by xhmikosr

Don't change the encoding, keep it as it is.

Changed 6 years ago by unwake

comment:5 Changed 6 years ago by unwake

I didn't mention the encode. I reupload it as mplayerc.7z, plz check it.

comment:6 Changed 6 years ago by xhmikosr

  • Owner set to xhmikosr
  • Status changed from new to assigned

Well you did in the previous file. I'll take a look and commit it if everything is ok.

comment:7 Changed 6 years ago by xhmikosr

BTW, mpcresources have to be updated too if this change is correct.

comment:8 Changed 6 years ago by xhmikosr

  • Cc sansnom05 added
  • Milestone set to 1.5

comment:9 Changed 5 years ago by xhmikosr

  • Cc v0lt jonasno added

comment:10 Changed 5 years ago by v0lt

I do not see any problems.
http://i.imgur.com/NfpkN.png

comment:11 Changed 5 years ago by xhmikosr

See the attached screenshots in the original message.
And see here http://msdn.microsoft.com/en-us/library/aa381013%28v=VS.85%29.aspx

So we don't use the same charset in all dialogs.

comment:12 Changed 5 years ago by v0lt

I do not understand the point. unwake corrupts fonts in his system. Why do so?

What should I do to see the bad fonts?

comment:13 Changed 5 years ago by xhmikosr

We do NOT use the charset in all our dialogs. We should use the same charset in all dialogs. If his fonts were corrupted then ALL dialogs would be broken. The problem must happen only on Chinese or whatever Asian system he is on.

comment:14 follow-up: Changed 5 years ago by xhmikosr

  • Owner changed from xhmikosr to v0lt

v0lt: I think you missed line 607 in mplayerc.rc.

When you are done close this issue.

Thanks.

comment:15 in reply to: ↑ 14 Changed 5 years ago by v0lt

Replying to xhmikosr:

v0lt: I think you missed line 607 in mplayerc.rc.

I see this:

IDD_COMPROPERTYPAGE DIALOGEX 0, 0, 5, 5
STYLE DS_SETFONT | WS_CHILD
FONT 8, "MS Sans Serif", 0, 0, 0x0
BEGIN
END

I do not know why this is necessary. Font "MS Sans Serif" and "ANSI_CHARSET" are used only in this place. I can change, but it will be correct?

...more..
In the mplayerc.sc.rc I see a line
FONT 8, "Tahoma", 400, 0, 0x0
instead
FONT 8, "MS Shell Dlg", 400, 0, 0x1
It is so specially made ​​for Chinese people or is it a bug?

comment:16 Changed 5 years ago by xhmikosr

At line 607 in mplayerc.rc I guess it should be like the other dialogs, FONT 8, "MS Shell Dlg", 400, 0, 0x1. Not sure where that dialog is used though.

As for the Chinese/Japanese/Korean resource files, don't change anything regarding the font or the charset. I don't know the consequences so let's leave it as it is for now.

comment:17 Changed 5 years ago by v0lt

  • Resolution set to fixed
  • Status changed from assigned to closed

fixed in r3119

comment:18 Changed 5 years ago by thevbm

  • Milestone changed from 1.6.x to 1.5.2

comment:19 Changed 4 years ago by xhmikosr

  • Cc sansnom05 v0lt jonasno removed
  • Component changed from Accepted, Patch welcome, we will not work on this to Solved
Note: See TracTickets for help on using tickets.