Opened 21 months ago

Closed 20 months ago

Last modified 17 months ago

#5519 closed Bug (fixed)

MPC wont load subtitle containing negative times

Reported by: spuuunit Owned by: underground78
Priority: high Milestone: 1.7.10
Component: Subtitles Version: 1.7.7
Severity: normal Keywords: subtitles negative
Cc: underground78 Evaluation: reproduced

Description

When timing subtitles to a video, you sometimes end up with negative times. This is how it looks like after using my subtitle editing program (I assume the syntax for negative times should look like this?):

1
00:00:-45,-237 --> 00:00:-42,-214
Downloaded From www.AllSubs.org

2
00:00:35,014 --> 00:00:37,289
Översatt av: Laban4567
www.divxsweden.net

3
00:00:37,326 --> 00:00:42,579
Text hämtad från www.Undertexter.se

My problem is that when I play a video, it doesn't play the belonging subtitle file (seen in Play > Subtitles). What could be wrong? I've never had this issue before...

Change History (10)

comment:1 Changed 21 months ago by underground78

  • Cc underground78 added
  • Evaluation set to reproduced
  • Status changed from new to evaluated

I can reproduce although in theory I see nothing that would prevent parsing. I will try to have a closer look tomorrow.

comment:2 Changed 21 months ago by underground78

  • Owner set to underground78
  • Status changed from evaluated to accepted

I have found and fixed the problem.

comment:3 Changed 21 months ago by spuuunit

I just reinstalled MPC with the latest version, but I still got the issue. Or will it be included when the next update is released maybe?

comment:4 Changed 21 months ago by kasper93

It will be included in next beta build. Ticket will be closed with appropriate message when its released.

Last edited 21 months ago by kasper93 (previous) (diff)

comment:5 follow-up: Changed 21 months ago by spuuunit

Just in the Beta? But when the new normal release finally is out, it will be included in there i suppose?

comment:6 in reply to: ↑ 5 Changed 21 months ago by underground78

Replying to spuuunit:

Just in the Beta? But when the new normal release finally is out, it will be included in there i suppose?

Of course!

comment:7 Changed 21 months ago by spuuunit

Well then, thanks for the fix! =)

comment:8 Changed 20 months ago by Underground78 <underground78@…

  • Resolution set to fixed
  • Status changed from accepted to closed

In 1d9662:

SRT subtitles: Support parsing files with negative timecodes.

It might happen if the subtitles were resynchronized and there is no good reason to forbid that.

Fixes #5519.

comment:9 Changed 20 months ago by underground78

  • Milestone set to next release

Will be in the nightly builds as of version 1.7.9.56.

comment:10 Changed 17 months ago by thevbm

  • Milestone changed from next release to 1.7.10

Milestone renamed

Note: See TracTickets for help on using tickets.