Opened 22 months ago

Closed 21 months ago

Last modified 17 months ago

#5464 closed Bug (fixed)

Bug in D3D FS

Reported by: Aleksoid1978 Owned by: underground78
Priority: normal Milestone: 1.7.10
Component: Video Renderers Version: 1.7.9
Severity: normal Keywords:
Cc: Evaluation:

Description

Bug - if main window and D3D FS is on different monitor and minimize main window - D3D FS window don't receive any mouse message ... don't receive any message.

Here the patch:

@@ -14962,7 +14962,7 @@ bool CMainFrame::CreateFullScreenWindow()
     monitor.GetMonitorRect(monitorRect);
 
     return !!m_pFullscreenWnd->CreateEx(WS_EX_TOPMOST | WS_EX_TOOLWINDOW, _T(""), ResStr(IDS_MAINFRM_136),
-                                        WS_POPUP | WS_VISIBLE, monitorRect, this, 0);
+                                        WS_POPUP | WS_VISIBLE, monitorRect, nullptr, 0);
 }
 
 bool CMainFrame::IsD3DFullScreenMode() const

Change History (4)

comment:1 Changed 22 months ago by underground78

  • Component changed from General to Video Renderers
  • Owner set to underground78
  • Status changed from new to accepted

I already have a fix for this issue which does not reintroducing other bugs.

comment:2 Changed 21 months ago by Underground78 <underground78@…

  • Resolution set to fixed
  • Status changed from accepted to closed

In 14d790d:

Fix: Clicking on the D3D fullscreen window did nothing in some cases.

If the main window was on minimized while the D3D fullscreen window was displayed on another screen, it was impossible to use the mouse buttons to play, pause, exit fullscreen, etc.

This commit reverts 68d512e19e53a705d7306f0ee235654e8bbb0952 while still keeping the correct behavior when using on top.

Fixes #5464.

comment:3 Changed 21 months ago by underground78

  • Milestone set to next release

Will be in the nightly builds as of version 1.7.9.20.

Last edited 21 months ago by underground78 (previous) (diff)

comment:4 Changed 17 months ago by thevbm

  • Milestone changed from next release to 1.7.10

Milestone renamed

Note: See TracTickets for help on using tickets.