Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#5418 closed Bug (fixed)

Keyframe seek doesnt work with external audio

Reported by: kolacl Owned by: Underground78
Priority: normal Milestone: 1.7.9
Component: General Version: 1.7.8
Severity: normal Keywords:
Cc: Evaluation:

Description

How to reproduce:
Have a video file (tested with mkv and avi)
Put an external audio file (or just any audio file, tested with mp3 and ac3) into same folder, give it same name as video (except for extension of course)
Open video in MPC-HC
Press Shift-Left or Right Arrow. It should jump to next/prev keyframe. Nothing happens.
Shift-Click on the seekbar. It should quickly jump to nearest keyframe. Instead of that, it does a slow CPU intensive seek (observable especially on a slower computer).
Remove the audio file, reopen video.
Keyframe seeking works as expected.

Change History (6)

comment:1 Changed 5 years ago by Underground78

Owner: set to Underground78
Status: newaccepted

Confirmed, seeking on keyframe gets confused by the multiple source filters. It's an easy fix though.

comment:2 Changed 5 years ago by Underground78

Status: acceptedreviewing

Here is a test build with the fix if you want to try it.

comment:3 Changed 5 years ago by kolacl

Seeks by keyframes correctly. Thank You!

comment:4 Changed 5 years ago by Underground78 <underground78@…

Resolution: fixed
Status: reviewingclosed

In 49962e:

Fix fast seek (to key-frame) when using an external audio track.

Make sure to get the key-frames from the main file source filter.

Fixes #5418.

comment:5 Changed 5 years ago by Underground78

Milestone: next release

Will be in the nightly builds as of version 1.7.8.176.

comment:6 Changed 5 years ago by thevbm

Milestone: next release1.7.9

Milestone renamed

Note: See TracTickets for help on using tickets.