Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#5262 closed Bug (fixed)

"Previous/Next Subtitle" Commands goes wrong

Reported by: NiMa Taheri Owned by: Underground78
Priority: normal Milestone: 1.7.9
Component: Subtitles Version: 1.7.8
Severity: normal Keywords:
Cc: Evaluation:

Description

Hey guys,

I got this cool program called "Sublight" which automatically downloads subtitle when you hand it your movie file. This program puts its stamp in the end of the srt-file it downloads, which is like :

9999
00:00:0,500 --> 00:00:2,00
<font color="#ffff00" size=14>www.tvsubtitles.net</font>

This confuses "Previous/Next Subtitle" commands and makes them go wrong. "Previous Subtitle" seeks to the beginning of the file no matter where you currently are, and "Next Subtitle" doesn't work completely.

Change History (4)

comment:1 Changed 5 years ago by Underground78

Owner: set to Underground78
Status: newaccepted

comment:2 Changed 5 years ago by Underground78 <underground78@…

Resolution: fixed
Status: acceptedclosed

In 02abdec:

Fix the "Go to next/previous subtitle" feature for some subtitles.

The code wrongly assumed the subtitle times to be sorted.

Fixes #5262.

comment:3 Changed 5 years ago by Underground78

Milestone: next release

Will be in the nightly builds as of revision 1.7.8.27.

comment:4 Changed 5 years ago by thevbm

Milestone: next release1.7.9

Milestone renamed

Note: See TracTickets for help on using tickets.