Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#5028 closed Task (fixed)

More intuitive "After Playback" event handling

Reported by: LuanMax Owned by: kasper93
Priority: normal Milestone: 1.7.9
Component: User Interface Version: nightly, specify
Severity: normal Keywords: 1.7.7.73
Cc: Evaluation:

Description

I think we still have a problem with the currently "After Playback" event handling - from the average user's point of view, which is due to the distinction between "View" > "Options" > "Playback" > "After Playback" (every-time event) and "Play" > "After Playback" (one-time event).

For example, if I

(1) set "View" > "Options" > "Playback" > "After Playback" > "Play next file in the folder",
(2) set and unset some event under "Play" > "After Playback",

I get the OSD message: "After Playback: Do nothing" - but (taken in isolation, and this is how it's perceived from user) this isn't true because "Play next file in the folder" will still be executed.

To solve this problem regarding (A) program message and (B) more intuitive user interface I wish to propose that

(A) The OSD "After Playback" message should always fall back to the configured "After Playback" every-time event, because imho the OSD "After Playback" message should always show the actually valid (next) "After Playback" event.

(B) Additionally, configured "After Playback" every-time events such as, for example, "Play next file in the folder", should always be shown as pre-checked under "Play" > "After Playback" (if they can be associated with both event types). This would also have the advantage of the possibility to deactivate "After Playback" every-time events just for one-time. And beyond this there's no need to activate an "After Playback" every-time event as "After Playback" one-time event as well.

Attachments (1)

mpc-hc_ote_dots.jpg (56.8 KB) - added by LuanMax 5 years ago.

Download all attachments as: .zip

Change History (25)

comment:1 Changed 5 years ago by kasper93

Owner: set to kasper93
Status: newaccepted

comment:2 Changed 5 years ago by dannn

in continuation of #4970 as well
To make it perfect, please consider a small suggestion: allow there to be a shortcut to change the "Every Time" "Play Next File in Folder"/"Do nothing" events (like until 1.7.6).

Thank you greatly!

comment:3 Changed 5 years ago by dannn

Still affecting 1.7.8.

comment:4 Changed 5 years ago by LuanMax

Hi kasper93, I would just like to ask if there's any news about it... :)

comment:5 Changed 5 years ago by kasper93

Sorry, for the delay. I will look into it soon.

comment:6 Changed 5 years ago by kasper93

What do you think about this behavior? MPC-HC.1.7.8.203.x86_#5028.7z

Last edited 5 years ago by kasper93 (previous) (diff)

comment:7 Changed 5 years ago by LuanMax

Thanks, good work! And of course, this way you can't disable every-time events via one-time events (as "Do nothing"), but in a strict sense it's only consistent, so I would be fine with it.

Last edited 5 years ago by LuanMax (previous) (diff)

comment:8 Changed 5 years ago by kasper93

I was thinking about adding "Do nothing" and wasn't completely sure, but If you think it will be useful. Here is build test build.

comment:9 Changed 5 years ago by LuanMax

Yep, with this build the selection is definitively complete. The advantage would be of being able to disable every-time events just once.

I can see "Do nothing" as one-time event with English language only. Is this due to the test mode?

comment:10 Changed 5 years ago by kasper93

I can see "Do nothing" as one-time event with English language only. Is this due to the test mode?

Yep, I probably didn't sync translations.

comment:11 Changed 5 years ago by ever_green

Hello, Kasper93 and LuanMax.
Would you improve One-time events order and add a separator? "After Playback" menu items will become something like:

Do Nothing
Play next file in the folder
Turn off the monitor
Exit
― Windows Menu ― (Separator)
Log Off
Lock
Stand By
Hibernate
Shutdown

What do you think about my suggestion?

Last edited 5 years ago by ever_green (previous) (diff)

comment:12 Changed 5 years ago by Underground78

This doesn't really seem useful in my opinion.

comment:13 Changed 5 years ago by LuanMax

I would like to keep it simple and easily accessible without separator or even sub menu here. But I have nothing against another order of the one-time events - which would not need to set apart from every-time events. Then I would rather prefer a comparable order of the events.

Last edited 5 years ago by LuanMax (previous) (diff)

comment:14 Changed 5 years ago by ever_green

How about changing the order? I think they should make two blocks.
It will become something like:
Do Nothing
Play next file in the folder
Turn off the monitor
Exit
Stand By
Hibernate
Shutdown
Log Off
Lock

comment:15 Changed 5 years ago by kasper93

I don't see any gain in reordering this menu. I don't want to change things just because.

comment:16 Changed 5 years ago by kasper93

Resolution: fixed
Status: acceptedclosed

In 6bfd33:

Display OSD message for every time after playback event if once event is
disabled.

Also mark every time event in context menu with dot and disable this
item.

Fixes #5028

comment:17 Changed 5 years ago by kasper93

Milestone: next release

comment:18 Changed 5 years ago by LuanMax

@kasper93 Hm, I think there's a small bug.

Can you just double check this?

(1) Start MPC-HC with every-time event "Play next file in the folder"
(2) Play a video file
(3) Set every-time event "Do nothing"
(4) Set one-time event "Play next file in the folder"

Now a dot is shown instead of a check mark before the one-time event "Play next file in the folder".

Changed 5 years ago by LuanMax

Attachment: mpc-hc_ote_dots.jpg added

comment:19 Changed 5 years ago by kasper93

Thanks, will fix that.

comment:20 in reply to:  15 Changed 5 years ago by LuanMax

Replying to kasper93:

I don't see any gain in reordering this menu. I don't want to change things just because.

As I said, imho the only thing you could slightly improve here would be for some kind of a comparable order between every-time (drop down options menu) and one-time (main menu) events. - It just came into my mind again when I was testing all these combinations. :) Of course then it would be irrelevant what exactly would be (slightly) changed.

comment:21 Changed 5 years ago by kasper93

Please see if everything works in this build.

comment:22 Changed 5 years ago by LuanMax

Great, the minor bug is fixed and also I found no other problems. Finally you could apply the new order to the order in the key command panel (the events are still listed in the old order here). Then it would be perfect. ;)

comment:23 Changed 5 years ago by LuanMax

With last nightly the "Do Nothing" key command isn't on top... just before the new stable, only as a short note. Thanks again!

comment:24 Changed 5 years ago by thevbm

Milestone: next release1.7.9

Milestone renamed

Note: See TracTickets for help on using tickets.