Opened 3 years ago

Closed 13 months ago

Last modified 3 weeks ago

#4779 closed Feature Request (fixed)

Improving subtitles

Reported by: stayfun Owned by:
Priority: normal Milestone: 1.7.11
Component: Subtitles Version: 1.7.6
Severity: normal Keywords: subtitles, translation, user interface
Cc: Evaluation:

Description

The subtitle section in the main menu (via File) can be simplified to 2 items (instead of current 3):

  • Local subs
    • Load
    • Save
  • Online subs
    • Search
    • Upload
    • Download

The context-menu can be unified to the same structure for consistency. Also, the submenu item "Search" could use an easy shortcut.

Last thing:
When using the download function, results are shown in an opened window. It would be nice to give focus to the result similar to the select GUI language for MPC. And it would be nice to show somewhere the exact search string.

Change History (7)

comment:1 Changed 3 years ago by stayfun

To jump to the needed subtitle-file in the overlay window, a setting (called options in MPC) could be used as well. Named something like "default sub language" or "Focus for suggested subtitle language".

Showing the exact search string could ease manual searching (without or with wrong results) or interpreting search results.

I believe those few small adjustments can mean a lot for usability to all subtitle-users.

Last edited 3 years ago by stayfun (previous) (diff)

comment:2 Changed 3 years ago by ioannis

@stayfun: you could try out https://github.com/mpc-hc/mpc-hc/pull/123 and post comments in the PR if you like.

comment:3 Changed 3 years ago by stayfun

Thnx; That work covers mentioned suggestions! However,

I tried it briefly and it got me stuck if I need to decide which online sub is the best. I can only select a downloaded sub once, the first time. But maybe the first sub tried was the better one and I would prefer to use it above the next downloaded sub? Maybe caching it and make it available via context menu to switch back to the first?

Also, I miss the former "search" option, which opens up a tab to search provider with movie-id. I think it can be re-implemented as a button in the OSD (but with regex'ed moviename) for easy access to manual searching when there are no results.

Last edited 3 years ago by stayfun (previous) (diff)

comment:4 Changed 3 years ago by ioannis

@stayfun: all downloaded subtitles are available in context menu just as before (including additional information) and active subtitle can be changed by selecting a different menu item.

Pressing "D" at any time will open the subtitles search dialog you mentioned were you can find a list of all available matches for each subtitles providers selected in options, and the ability to download additional subtitles if the one downloaded automatically is not a perfect match.

It is best if you limit the search to specific languages to get more relevant results.

PS: its best if you leave any comments on the PR as this mod is not included in the code base yet and devs cannot provide any support for it.

comment:5 Changed 13 months ago by Underground78 <underground78@…

  • Owner set to Underground78 <underground78@…>
  • Resolution set to fixed
  • Status changed from new to closed

In 1f3d4a:

Document the tickets fixed by the new subtitle downloader/uploader.

Fixes #2022, #4779, #5193 and #5406.

comment:6 Changed 13 months ago by underground78

  • Milestone set to next release
  • Owner Underground78 <underground78@… deleted

comment:7 Changed 3 weeks ago by thevbm

  • Milestone changed from next release to 1.7.11

Milestone renamed

Note: See TracTickets for help on using tickets.