Opened 3 years ago

Closed 20 months ago

Last modified 17 months ago

#4047 closed Feature Request (fixed)

Backporting and general improvement of the custom audio renderer

Reported by: jeebjp Owned by:
Priority: normal Milestone: 1.7.10
Component: Internal Filters Version: nightly, specify
Severity: normal Keywords: backport, mpc_audio_renderer, wasapi
Cc: alexmarsev, underground78 Evaluation:

Description

As noted in #4044 , there have been improvements to the audio renderer in MPC-BE. including and not limited to seemingly more working WASAPI usage. Usable parts of this work should be backported.

A separate implementation of the WASAPI parts can be found in mpv, in case the MPC-BE code is not deemed usable. One has to note, though, that this one is not in any way or form related to DirectShow.

P.S. Added alexmarsev as CC as well since U78 mentioned he had poked around this originally.

Change History (3)

comment:1 Changed 3 years ago by alexmarsev

About mpc-be implementation:

  1. It doesn't support playback speed adjustments.
  2. It depends (rather indirectly) on ffmpeg.
  3. It doesn't read back the audio device buffer status and doesn't adjust the graph clock, that results in (possibly growing) video/audio desync.

Personally, I wouldn't use their implementation at all, or at least at its current state. Still I'm not satisfied with the default dsound renderer and don't like reclock much either. So I may put something standalone together someday, but it's not in my priorities. Maybe I'll get there in half an year or something, dunno.

So if anyone wants to backport anything to the current MpcAudioRenderer they're free to go, it's rather dead at the moment anyway.

comment:2 Changed 20 months ago by alexmarsev

  • Milestone changed from next release placeholder to next release
  • Resolution set to fixed
  • Status changed from new to closed

I've implemented the audio renderer after all, and we now use it mpc-hc. Better late than never, I guess.

P.S. Looking at my previous message here, and it appears rather rude. Sorry if it did offend anyone, that wasn't my intention.

comment:3 Changed 17 months ago by thevbm

  • Milestone changed from next release to 1.7.10

Milestone renamed

Note: See TracTickets for help on using tickets.