Opened 4 years ago

Closed 4 years ago

#2471 closed Bug (fixed)

DVR-MS opening crash

Reported by: s-h-a-d-e-r Owned by:
Priority: normal Milestone: 1.6.3
Component: General Version: nightly, specify
Severity: major Keywords: DVR-MS
Cc: v0lt, underground78 Evaluation:

Description

Tested the player behavior with .dvr-ms files (see ticket #2399) again, but with current SVN version (1.6.3.5364 x86). Behavior has changed. Now player just crashes when opening .dvr-ms files.

No matter, double-click, or drag-n-drop, or Ctrl+Q.
Tryed to disable/enable internal MPEG/2/etc source filters/decoders - no changes.

OS is Windows 7 32-bit.

Crash dump is attached.
Links to the samples are in ticket #2399.

Last release version 1.6.2.4902 is still behaves as described in ticket #2399 :)

Attachments (1)

mpc-hc.exe.1.6.3.5364.dmp (113.4 KB) - added by s-h-a-d-e-r 4 years ago.
crash dump of MPC-HC SVN 1.6.3.5364 when opening .dvr-ms file

Download all attachments as: .zip

Change History (14)

Changed 4 years ago by s-h-a-d-e-r

crash dump of MPC-HC SVN 1.6.3.5364 when opening .dvr-ms file

comment:1 Changed 4 years ago by underground78

  • Cc underground78 added

Is r5364 the first build which crashes (try of example some builds for http://xhmikosr.1f0.de/mpc-hc/old/)?

comment:2 Changed 4 years ago by s-h-a-d-e-r

Performed such a test:

(1) - Start MPC-HC.
(2) - open DVR-MS sample by Ctrl+Q. Wait (1-3 seconds) for beginning of playback (otherwise player may hang or crash).
(3) - open DVR-MS sample by Ctrl+Q again. Wait for beginning of playback.
(4) - open DVR-MS sample by double-click. Wait for beginning of playback.
(5) - open DVR-MS sample by drag-n-drop. Wait for beginning of playback (4 files are playing simultaneously at this moment).
(6) - close MPC-HC.

Did this 2 (if all ok) - 4 (if not OK) times per each SVN build.

Builds:

5139 - ОК twice
5147 - OK twice, hanged on (3) once, crashed on (6) once
5170 - hanged on (3) twice, сrashed on (6) twice
5190 - OK once, crashed on (6) three times
5205 - OK once, crashed on (6) three times
5210 - OK once, crashed on (6) three times
5229 - OK once, crashed on (6) three times
5242 - OK once, crashed on (6) three times
5260 - OK twice, crashed on (6) two times
5270 - OK once, crashed on (6) three times
5281 - OK twice, crashed on (4) once, crashed on (6) once
5292 - crashed on (2) twice
5305 - crashed on (2) twice
5322 - crashed on (2) twice
5336 - crashed on (2) twice
5352 - crashed on (2) twice
5364 - crashed on (2) twice
5373 - crashed on (2) twice

So, SVN 5281 was the last one build, which plays DVR-MS :)
From SVN 5292, and so on, opening DVR-MS file causes player to crash immediately :)

comment:3 Changed 4 years ago by s-h-a-d-e-r

If I open only one DVR-MS file, e.g. do step (1), then any ONE step of (2)-(5), then (6) - all SVN builds from 5139 till 5281 work fine.

comment:4 follow-up: Changed 4 years ago by s-h-a-d-e-r

One more thing.

1 - open MPC-HC
2 - open DVR-MS file (it begins playing)
3 - "File" -> "Close" (or Ctrl+C)
In player's statusbar, mesasage "closed" appears. But video continues playing.
I think, that's it.

Reproduced on release v1.6.2.4902, SVN 1.6.3.5170, 5281, all 32-bit. OS is Windows 7 32-bit.

comment:5 Changed 4 years ago by v0lt

Uncheck "MPEG Audio" in the internal filter list.

comment:6 Changed 4 years ago by v0lt

check the r5554

comment:7 in reply to: ↑ 4 Changed 4 years ago by s-h-a-d-e-r

Replying to v0lt:

Uncheck "MPEG Audio" in the internal filter list.

Replying to v0lt:

check the r5554

Didn't found compiled build 5554, only 5542 and 5555 (and so on). Checked build 5555 and current one - 5572. Disabled/enabled "MPEG Audio", "MPEG-1 Video", "MPEG-2 Video", "MPEG-2 Video (DXVA)", "MPEG TS/PS/PVA" - all the same. Results: First - it does play DVR-MS files again. Second - the bug is also present :)

Replying to s-h-a-d-e-r:

One more thing.

1 - open MPC-HC
2 - open DVR-MS file (it begins playing)
3 - "File" -> "Close" (or Ctrl+C)
In player's statusbar, mesasage "closed" appears. But video continues playing.
I think, that's it.

Reproduced on release v1.6.2.4902, SVN 1.6.3.5170, 5281, all 32-bit. OS is Windows 7 32-bit.

This is the shortest description of the bug. It is also present on builds 5555 and 5572.

comment:8 Changed 4 years ago by v0lt

I see a bug and I do not know why it happens. But now the player does not crash.

comment:9 Changed 4 years ago by underground78

I'm also not sure why it happens, it seems specific to the StreamBufferSource filter. I have some ideas I'm willing to test but I haven't had time yet.

comment:10 Changed 4 years ago by v0lt

I partially fixed this problem.
But after moving to GitHub, I can not say the revision number (stupid git).

comment:11 Changed 4 years ago by underground78

Commit 36deabbb5a36e05e670bafea40c8dbbdcb113191 is r5662. I will try to find a way to keep a translation table somewhere. It will also be easier when we will have moved to our own Trac with Git integration.

comment:12 Changed 4 years ago by s-h-a-d-e-r

Tested DVR-MS playback on current release (v1.6.3.5818 x86) and current SVN (r5857 x86). OS is Windows 7 32-bit. Works fine. No crashes. "File - close" works. Opening video file of any supported format by Ctrl+Q, drag'n'drop, double-click, while DVR-MS file is playing - works correctly. IMHO, #133, #2399 and this one (#2471) can be closed :)

comment:13 Changed 4 years ago by underground78

  • Component changed from New to Solved
  • Milestone changed from next release placeholder to 1.6.3
  • Resolution set to fixed
  • Status changed from new to closed

Good to know. :)

Note: See TracTickets for help on using tickets.