Opened 3 years ago

Closed 3 years ago

#2234 closed Patch (fixed)

Changed some UI fonts according to the OS

Reported by: demi_alucard Owned by: demi_alucard
Priority: normal Milestone: 1.6.2
Component: General Version: 1.6.1.4235
Severity: minor Keywords: fonts segoe
Cc: XhmikosR, Underground78 Evaluation:

Description

About fonts.patch:
This patch changes some UI fonts to their modern versions on Vista+ OSs. Everything should be unchanged in XP.

About winapiutils.patch:
This change is needed for the use of WinAPIUtils.h in projects that do not have dx9.h on their include path, like 'filters'.

Attachments (4)

fonts.patch (4.2 KB) - added by demi_alucard 3 years ago.
winapiutils.patch (720 bytes) - added by demi_alucard 3 years ago.
#2234 fonts.patch (5.1 KB) - added by xhmikosr 3 years ago.
#2234 fonts v2.patch (3.9 KB) - added by demi_alucard 3 years ago.

Download all attachments as: .zip

Change History (10)

Changed 3 years ago by demi_alucard

Changed 3 years ago by demi_alucard

comment:1 Changed 3 years ago by demi_alucard

Remarks:
I didn't change the default subtitle font because sometimes people rely on the defaults for line breaking, etc, etc on srts.

If I missed any place I should change, please tell me.

All new fonts aren't much different from the old ones (except they work better with ClearType) and are the system default on clean installations of Vista and 7. I doubt people will notice (or complain) but polish is never enough. Besides, we have to move forward, we can't stay stuck in the last decade.

comment:2 Changed 3 years ago by xhmikosr

Just a couple of notes: the InternalPropertyPage font doesn't look good on my OS at least (Win7), the AppSettings code seems to be the reverse code. Attached an updated patch.

Perhaps we shouldn't change the InternalPropertyPage font? Or maybe use a better looking one?

Changed 3 years ago by xhmikosr

comment:3 Changed 3 years ago by demi_alucard

Damn SVN...
Consolas is the new monospace font included with Vista. Visual Studio also uses Consolas on VS2010 and newer. Could you try fiddling with the font size and see if it is of your liking?
Your patch looks OK.

comment:4 Changed 3 years ago by xhmikosr

Then maybe the font size should be bigger in the InternalPropertyPage? Maybe Underground78 has a suggestion.

Changed 3 years ago by demi_alucard

comment:5 Changed 3 years ago by demi_alucard

  • Keywords fonts segoe added

Updated last patch to do not modify InternalPropertyPage.
Although Consolas is horizontally more condensed than Lucida Console, it needs a higher font size to be readable, using more vertical space, meaning that you would read fewer lines. For this same reason, we resolved to also do not touch the MediaInfo tab.

The only place that still uses Tahoma for its dialog are the Folder Selection Dialog. There is no need to modify them because they will only be used by XP. A new commit will change all instances of the older folder selection dialog to the new one recommended by Microsoft for Windows Vista or newer based on IFileDialog.

comment:6 Changed 3 years ago by underground78

  • Component changed from New to Solved
  • Milestone changed from next release placeholder to next release
  • Resolution set to fixed
  • Status changed from new to closed

Commited as r4614.

Note: See TracTickets for help on using tickets.