Opened 5 years ago

Closed 13 months ago

Last modified 3 weeks ago

#2022 closed Feature Request (fixed)

Subtitle new features

Reported by: donor Owned by:
Priority: normal Milestone: 1.7.11
Component: Subtitles Version: 1.6.0.4014
Severity: major Keywords: subtitle, subtitles, language, download, upload, ISO 639-3
Cc: ioannis Evaluation:

Description

This is a summary of the tickets #296, #1191, #1888 extended with some extra information and suggestions.

The following features for subtitle handler would be desirable:

  • language preference
  • subtitle sync correction
  • multi-server support
  • quick upload
  • auto-download, auto-save

1, Language preference

MPC-HC would need a new text input box in Options / Subtitles / Misc, "Preferred language(s)". The user could list languages separated by comma using the ISO 639-3 (Alpha-3) language codes to define his expected subtitle language(s).

When he opens a movie and selects File / Subtitle database / Download... he should see the subtitles ordered in a way that the subtitles with the preferred languages are the firsts.

Default value might be: "eng, spa, cmn, hin, ara"

ISO 639-3 codes: http://en.wiktionary.org/wiki/Appendix:ISO_639-3_language_codes

2, Subtitle sync correction

It is often the case, that the user downloads a subtitle which is not exactly in sync with the movie. The easiest way to correct it (which works 90%+ of the time) is that he tells the corrector logic when the first and the last line should be show (e.g. the first and the last spoken line in the movie).

From this information it is obvious how much it should be shifted and how much it needs its speed to be changed.

You can see this feature in Subtitle Workshop 4, Edit / Timings / Adjust / Adjust subtitles... / Simple

3, Multi-server support

OpenSubtitles.org is the only supported subtitle site by default at the moment, but there are others as well, who implement its XML Web Service interface. It would be beneficial (and it would take not a long time) to collect all other sites with the same programming interface. The drop-down list in Options / Subtitles / Misc / Online database should be changed to a multi-select checklist, offering the option to use more than one subtitle database site in a parallel way.

The subtitle download method should be changed to a multi-threaded async method to keep the user experience great.

More information about OSDb XMLRPC interface:
http://trac.opensubtitles.org/projects/opensubtitles/wiki/XMLRPC

4, Although MPC-HM has the File / Subtitle database / Upload... option, but it only opens up your default browser with the "Sorry, upload is not possible yet. For upload use some program" message.

This option should be available only if a movie with an external subtitle in the supported format was loaded. After the user made sure that the sync is ok, he could upload it with one click.

MPC-HC should display small information panel, showing the hash of the file used for uploading, displaying the movie information got back from the subtitle upload site with a dropdown list to select the language, the subtitle site, and a confirmation button to accept the upload.

If the site does not support the file format or the subtitle is already on the site, MPC-HC should display an error message and cancel the operation.

If authentication is needed MPC-HC should display a form requesting username/password with an option to remember the entered data next time.

External browser should never be used to display messages.

5, Auto-download, auto-save

Two more checkboxes should be added to Options / Subtitles / Misc: "Auto-download" and "Auto-save".

If the auto-download is checked, MPC-HC should try to download the preferred languages when the user opens the movie if the file is not already downloaded.

If the auto-save is checked then if a new subtitle was downloaded which was not previously present, MPC-HC should silently save it as <movie's file name without the extension>.<language ISO 369-3 code>.<subtitle's file format extension> (e.g. "Inside.Job.LiMiTED.BDRip.XviD-DEFACED.eng.srt")

ISO 639-3 codes: http://en.wiktionary.org/wiki/Appendix:ISO_639-3_language_codes

Change History (6)

comment:1 Changed 5 years ago by thevbm

  • Cc aleksoid v0lt added

comment:2 Changed 3 years ago by thevbm

  • Cc aleksoid v0lt removed
  • Component changed from General to Subtitles
  • Milestone next release placeholder deleted

WIP PR:123

Last edited 3 years ago by thevbm (previous) (diff)

comment:3 Changed 3 years ago by thevbm

  • Cc ioannis added

comment:4 Changed 13 months ago by Underground78 <underground78@…

  • Owner set to Underground78 <underground78@…>
  • Resolution set to fixed
  • Status changed from new to closed

In 1f3d4a:

Document the tickets fixed by the new subtitle downloader/uploader.

Fixes #2022, #4779, #5193 and #5406.

comment:5 Changed 13 months ago by underground78

  • Milestone set to next release
  • Owner Underground78 <underground78@… deleted

comment:6 Changed 3 weeks ago by thevbm

  • Milestone changed from next release to 1.7.11

Milestone renamed

Note: See TracTickets for help on using tickets.